chisel icon indicating copy to clipboard operation
chisel copied to clipboard

add chisel level interface to PresetAnnotation

Open ekiwi opened this issue 4 years ago • 2 comments

Contributor Checklist

  • [x] Did you add Scaladoc to every public function/method?
  • [x] Did you add at least one test demonstrating the PR?
  • [x] Did you delete any extraneous printlns/debugging code?
  • [x] Did you specify the type of improvement?
  • [ ] Did you add appropriate documentation in docs/src?
  • [x] Did you state the API impact?
  • [x] Did you specify the code generation impact?
  • [x] Did you request a desired merge strategy?

Type of Improvement

  • new feature/API

API Impact

  • adds a new RequireResetIsInit trait
  • adds new global withResetIsInit function

Backend Code Generation Impact

  • none

Desired Merge Strategy

  • squash

Reviewer Checklist (only modified by reviewer)

  • [ ] Did you add the appropriate labels?
  • [ ] Did you mark the proper milestone (Bug fix: 3.3.x, [small] API extension: 3.4.x, API modification or big change: 3.5.0)?
  • [ ] Did you review?
  • [ ] Did you check whether all relevant Contributor checkboxes have been checked?
  • [ ] Did you mark as Please Merge?

ekiwi avatar Jan 07 '22 22:01 ekiwi

@jackkoenig Can we merge this?

ekiwi avatar Feb 12 '22 01:02 ekiwi

ask to merge this ;p

sequencer avatar Apr 02 '22 09:04 sequencer