chisel icon indicating copy to clipboard operation
chisel copied to clipboard
verified publisher icon chipsalliance

Fix ExtModule port's suggestedName not work

Open colin4124 opened this issue 6 years ago • 6 comments

Type of change: bug report

Impact: no functional change

Development Phase: implementation

Release Notes

ExtModule port's name should take suggestdName first as RawModule do

colin4124 avatar Nov 08 '19 03:11 colin4124

Can one of the admins verify this patch?

ghost avatar Nov 08 '19 03:11 ghost

ok to test

ucbjrl avatar Nov 08 '19 16:11 ucbjrl

The original trait NamedModuleTester extends MultiIOModule didn't support ExtModule, so I change to trait NamedModuleTesterBase due to it doesn't depend on MultiIOModule.

Changing trait NamedModuleTester extends MultiIOModule to trait NamedModuleTester extends MultiIOModule with NamedModuleTesterBase does not affect other code.

colin4124 avatar Dec 10 '19 10:12 colin4124

Also thank you for writing the test, that was a pretty clever way to do it :)

jackkoenig avatar Jan 06 '20 20:01 jackkoenig

We think this might have been fixed, needs to be tested.

azidar avatar Oct 27 '20 18:10 azidar

@azidar Do you want this to be fixed? If so, I can renew this PR for the latest version of the code base.

colin4124 avatar Nov 26 '21 08:11 colin4124