tinker icon indicating copy to clipboard operation
tinker copied to clipboard

Hotkeys and tabbed layout

Open Riateche opened this issue 13 years ago • 6 comments

I've added hotkeys for run, save, switching between editors. Also I've added tabbed layout. In this layout only one editor is visible. User can switch between editors using buttons above the editor or using hotkeys. This layout is very useful for small displays (e.g. laptops'). Both other layouts give too small editors.

Riateche avatar Jul 13 '12 18:07 Riateche

Very nice! I'm actually in the middle of refactoring a bunch of the code related to layouts, so we don't need an entire layout javascript object.

The new system relies on layouts being defined in a JSON format, more or less like this:

{
    "layouts": [{
        "cols": [0, 33, 67],
        "rows": [0, 50],
        "cells": [
            [0, 0, 1, 1],
            [0, 1, 1, 1],
            [1, 0, 1, 2],
            [2, 0, 1, 2]
        ]
    }, {
        "cols": [0, 50],
        "rows": [0, 33, 67],
        "cells": [
            [0, 0, 1, 1],
            [0, 1, 1, 1],
            [0, 2, 1, 1],
            [1, 0, 1, 3]
        ]
    }]
}

There's a bunch more changes coming as well. Anyway, this stuff looks really good and I can merge it but I cannot guarantee, at this point, that it will make it into the new repository, or that it will make it to the live site before I start using the new repos.

So, it's kinda up to you what you want me to do. Let me know! :)

chiel avatar Jul 13 '12 20:07 chiel

It will be nice if my tabs will appear on tinker.io site. It's the feature i'm really missing.

About further changes: I can suggest removing bottom bar. There are quite a few controls on this bar, they can be easily placed in top bar. This will increase vertical space. Also the logo and the information button should be merged (click on the logo should display information popup). Now the logo looks like broken button. And I think you should add "New" button.

Let me know when your pending changes appear in the repo.

Riateche avatar Jul 13 '12 20:07 Riateche

Yeah, so in the new iteration, all layouts are handled by the same code, and there will be the ability to show/hide panels, which will probably help a lot in this case. You can look at it a bit like jsbin, except with a few layouts to pick between.

Another thing that will happen is that the header and footer bars will get slightly less tall (probably, design is still in the works), which will also increase vertical space. The reason there's two bars at the moment is cause of the features that are still coming.

Anyway, there's lots happening, so I'm not how useful it would be to pull this in at this point in time. Let me know what you think. :)

chiel avatar Jul 14 '12 23:07 chiel

Ok, as you wish. I'll wait for your big changes.

Riateche avatar Jul 14 '12 23:07 Riateche

My time working on tinker is actually kinda limited at the moment, so I will probably go ahead and pull this in for now, but I cannot guarantee that it will be in the next iteration. Would that be an acceptable solution for the meantime?

chiel avatar Aug 13 '12 12:08 chiel

Of course I don't mind.

Riateche avatar Aug 13 '12 12:08 Riateche