sheepwall icon indicating copy to clipboard operation
sheepwall copied to clipboard

Refine IsContainFields function

Open TingyuHuang opened this issue 7 years ago • 1 comments

- Avoid copying fields.
- Pass the content by const referenceas to handle const
  string parameter. Copy it in the function by to_lower_copy.
- Declare as a static member function to avoid passing 'this' pointer.

Signed-off-by: Tingyu Huang [email protected]

TingyuHuang avatar Apr 04 '18 17:04 TingyuHuang

Pull Request Test Coverage Report for Build 46

  • 0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 47.619%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/http.cc 0 4 0.0%
<!-- Total: 0 4
Files with Coverage Reduction New Missed Lines %
src/http.cc 1 29.17%
<!-- Total: 1
Totals Coverage Status
Change from base Build 45: 0.0%
Covered Lines: 70
Relevant Lines: 147

💛 - Coveralls

coveralls avatar Apr 04 '18 17:04 coveralls