angular-loading-bar icon indicating copy to clipboard operation
angular-loading-bar copied to clipboard

add statusChanged event for status synchronization with 3th parties

Open pablodgonzalez opened this issue 10 years ago • 4 comments

pablodgonzalez avatar Apr 06 '15 15:04 pablodgonzalez

@chieffancypants You could check this pull request? I use this event for synchronizing the loading bar with other visuals elements. But is the bar which controlling load percentage Cheers!

pablodgonzalez avatar Jul 15 '15 16:07 pablodgonzalez

How frequently does this event get called? My only concern is that this could cause performance issues.

If this is the case, then it should be off by default and turned on via a config flag.

Also, PR's should be accompanied by appropriate unit tests.

@chieffancypants thoughts?

faceleg avatar Mar 16 '16 22:03 faceleg

Is there still a huge performance difference between $broadcast and $emit? If so, this should be changed to $emit, and just force people to listen on $rootScope, which I believe is way more common now anyway.

chieffancypants avatar Mar 16 '16 22:03 chieffancypants

Agree that listening on $rootScope is fine for this (therefore $emit)

I'll take @chieffancypants' silence on the config flag and off by default to mean he agrees. And tests :)

faceleg avatar Mar 16 '16 22:03 faceleg