chicagopython
adding meeting topic draft feature
This is a PR to address the following. More info to come, but creating a placeholder PR.
See the attached issue for information on how this works. https://github.com/chicagopython/chipy.org/issues/287
This PR requires one migration to add a new TopicDrafts table.
@JoeJasinski Really nice job on this feature! I left you a comment on Slack that talks a little bit more about this feature. Thanks for all of your hard work and your attention to detail :smile:
Also I'm unable to save an edit to a main meeting
Not sure how this is related.
@elmq0022 thanks for the feedback. I originally added that __hash__ method to try to resolve this delete issue, and thought that it had. However, looks like it needs another look. You are right, it is the default implementation; it had looked like the default implementation wasn't being used due to some of the inheritance, so I set it explicitly there. I'll take another look at it this weekend.
I agree that the email logic could be consolidated. I'll create another story where we can consider how we want to make some standard email logic.
Sounds great. I'm looking forward to the updated version 👍.
On Thu, May 21, 2020, 9:02 AM Joe Jasinski [email protected] wrote:
@elmq0022 https://github.com/elmq0022 thanks for the feedback. I originally added that hash method to try to resolve this delete issue, and thought that it had. However, looks like it needs another look. You are right, it is the default implementation; it had looked like the default implementation wasn't being used due to some of the inheritance, so I set it explicitly there. I'll take another look at it this weekend.
I agree that the email logic could be consolidated. I'll create another story where we can consider how we want to make some standard email logic.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/chicagopython/chipy.org/pull/288#issuecomment-632103906, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA2KPYCWMXFITAETOAYXY5TRSUYAVANCNFSM4MZFOBSQ .
@JoeJasinski, I missed your update. Do you need me to take a look at this one?