cheroot icon indicating copy to clipboard operation
cheroot copied to clipboard

Drop support for Python 3.5 and 2.7

Open jaraco opened this issue 3 years ago β€’ 2 comments

  • Add a py2-drop banner to the docs
  • Remove declared support for Python < 3.6
  • Remove compatibility code from wsgi
  • Remove compatibility code from cheroot
  • Remove compatibility code from cli
  • Remove compatibility code from connections
  • Remove compatibility code from errors
  • Remove compatibility code from makefile
  • Remove compatibility code from test__compat
  • Remove compatibility code from server
  • Remove compatibility code from testing
  • Remove compatibility code from threadpool
  • Remove compatibility code from ssl package
  • Remove compatibility code from test package
  • Remove Python 3.5 compatibility from _compat module
  • Add a changelog entry for v9.0.0

❓ What kind of change does this PR introduce?

  • [ ] 🐞 bug fix
  • [ ] 🐣 feature
  • [ ] πŸ“‹ docs update
  • [ ] πŸ“‹ tests/coverage improvement
  • [ ] πŸ“‹ refactoring
  • [x] πŸ’₯ other

πŸ“‹ What is the related issue number (starting with #)

Resolves #252

❓ What is the current behavior? (You can also link to an open issue here)

❓ What is the new behavior (if this is a feature change)?

πŸ“‹ Other information:

πŸ“‹ Contribution checklist:

(If you're a first-timer, check out this guide on making great pull requests)

  • [ ] I wrote descriptive pull request text above
  • [ ] I think the code is well written
  • [ ] I wrote good commit messages
  • [ ] I have squashed related commits together after the changes have been approved
  • [ ] Unit tests for the changes exist
  • [ ] Integration tests for the changes exist (if applicable)
  • [ ] I used the same coding conventions as the rest of the project
  • [ ] The new code doesn't generate linter offenses
  • [ ] Documentation reflects the changes
  • [ ] The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences

This change is Reviewable

jaraco avatar Jun 22 '22 01:06 jaraco

Codecov Report

Merging #510 (1396980) into main (f0f9764) will increase coverage by 1.45%. The diff coverage is 82.69%.

:exclamation: Current head 1396980 differs from pull request most recent head 06f2107. Consider uploading reports for the commit 06f2107 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #510      +/-   ##
==========================================
+ Coverage   80.80%   82.26%   +1.45%     
==========================================
  Files          27       28       +1     
  Lines        4413     3991     -422     
==========================================
- Hits         3566     3283     -283     
+ Misses        847      708     -139     

codecov[bot] avatar Jun 22 '22 01:06 codecov[bot]

This pull request fixes 4 alerts when merging 1396980c4a1abaab1758a6eb0077a7099a4107c9 into b7be66df6d08562e563fcf5ed9dd176b7130827d - view on LGTM.com

fixed alerts:

  • 3 for Unused import
  • 1 for Unused local variable

lgtm-com[bot] avatar Jun 22 '22 01:06 lgtm-com[bot]

This pull request fixes 4 alerts when merging ea92dc015d7595fed1069eaf209df5fa4e661841 into f0f97645bd527d765e79cbd205249d31b0fed949 - view on LGTM.com

fixed alerts:

  • 3 for Unused import
  • 1 for Unused local variable

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine :gear: that powers LGTM.com. For more information, please check out our post on the GitHub blog.

lgtm-com[bot] avatar Nov 19 '22 16:11 lgtm-com[bot]

This pull request fixes 4 alerts when merging 06f210784fded6b6bef405497eefee97a89c3215 into f0f97645bd527d765e79cbd205249d31b0fed949 - view on LGTM.com

fixed alerts:

  • 3 for Unused import
  • 1 for Unused local variable

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine :gear: that powers LGTM.com. For more information, please check out our post on the GitHub blog.

lgtm-com[bot] avatar Nov 19 '22 17:11 lgtm-com[bot]