Rujun Chen

Results 98 comments of Rujun Chen

Closing this issue because It's fixed in spring-cloud-azure 4.4.0. https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/spring/CHANGELOG.md#440-2022-09-26

Information update: 1. Link to PR: https://github.com/MicrosoftDocs/azure-dev-docs-pr/pull/3583 2. Link to quick start: https://review.docs.microsoft.com/en-us/azure/developer/java/spring-framework/configure-spring-cloud-stream-binder-java-app-kafka-azure-event-hub?branch=pr-en-us-3583&tabs=passwordless 3. Link to migration-guide: https://review.docs.microsoft.com/en-us/azure/developer/java/spring-framework/migrate-kafka-to-passwordless-connection?branch=pr-en-us-3583&tabs=azure-portal-permission%2Csign-in-azure-cli%2Cjava-kafka%2Cservice-connector-portal%2Cservice-connector-cli%2Cassign-role-service-connector

### Quick start feedback: Link to quick start: https://review.docs.microsoft.com/en-us/azure/developer/java/spring-framework/configure-spring-cloud-stream-binder-java-app-kafka-azure-event-hub?branch=pr-en-us-3583&tabs=passwordless 1. Add link to **Azure Active Directory (Azure AD) authentication** and **Shared Access Signatures (SAS) authentication**. ![image](https://user-images.githubusercontent.com/13167207/190569026-bf1957ae-79e7-4493-b9c4-edc6042ce95a.png) 1.1. Azure Active Directory...

## Feedback of Migration guide Link to migration-guide: https://review.docs.microsoft.com/en-us/azure/developer/java/spring-framework/migrate-kafka-to-passwordless-connection?branch=pr-en-us-3583&tabs=azure-portal-permission%2Csign-in-azure-cli%2Cjava-kafka%2Cservice-connector-portal%2Cservice-connector-cli%2Cassign-role-service-connector 1. `after` -> `since`. ![image](https://user-images.githubusercontent.com/13167207/190591975-b80c04bf-0673-4cf3-80a9-b543d9e167a5.png) BTW, why this feature is not written in the changelog? https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/spring/CHANGELOG.md 2. `The support for passwordless...

13. Now there is only `code after migration`. It's better to keep the `code before migration` at the same time. ![image](https://user-images.githubusercontent.com/13167207/190961366-ae6fb951-6951-413c-a9c0-7a49ada58cf2.png) ![image](https://user-images.githubusercontent.com/13167207/190961585-58463360-1ed0-4524-871d-f5ddd9d0d281.png) Here is `code before migration` created by myself:...

14. In current `Java` tab, it's using `org.apache.kafka:kafka-clients`. We should add some description about `azure-messaging-eventhubs`. It's official client to connect to Azure Event Hubs. 14.1. Can `azure-messaging-eventhubs` be used to...

15. It's better not use `master` branch. Because `master` branch may change. Use git tag instead. ![image](https://user-images.githubusercontent.com/13167207/190981434-a80b4e47-d3cd-4a9c-a912-d8c9570ce9e8.png)

16. Use constant value instead of raw string ![image](https://user-images.githubusercontent.com/13167207/190991120-12df6d30-cd98-434b-b02f-86a04212955f.png) Here is the code in my localhost: ![image](https://user-images.githubusercontent.com/13167207/190991409-207add9e-8b88-4c9c-ada8-c3f7c8d878a3.png) More context: pom file: ```xml 4.0.0 com.azure.spring.password.less.migration.kafka.java after-migration 1.0.0-SNAPSHOT 1.8 1.8 org.apache.kafka kafka-clients...

17. Problem: `Missing required configuration "key.serializer" which has no default value.` ![image](https://user-images.githubusercontent.com/13167207/190991933-d93c4b50-b8ee-4902-8cc1-cf3eeed1e94c.png) Fixed by adding the 2 properties: ```java properties.put(ProducerConfig.KEY_SERIALIZER_CLASS_CONFIG, StringSerializer.class.getName()); properties.put(ProducerConfig.VALUE_SERIALIZER_CLASS_CONFIG, StringSerializer.class.getName()); ``` ![image](https://user-images.githubusercontent.com/13167207/190992601-81303ce5-6fa2-4550-a881-ddb4e138b877.png)

18. Problem: `JAAS config entry not terminated by semi-colon` ![image](https://user-images.githubusercontent.com/13167207/190993026-129d324d-37d1-4d27-9574-e3662f3f9c3b.png) Fixed by adding semi-colon: ![image](https://user-images.githubusercontent.com/13167207/190993242-54289486-18fc-4504-abd0-16e54eaa91d6.png)