Relax constraint on diff-lcs < 1.4

[Annih]

Describe the Enhancement

In June 2020, a bug report has been created on diff-lcs about compat issue with chef-cli: halostatue/diff-lcs#65 Since the, a < 1.4.0 constraint has been added to chef-cli dependency on diff-lcs. I want to relax this constraint and allow the use of recent versions like 1.5.1 because it fixes actual bugs in the diff computation.

It seems the only use of diff-lcs is for the chef-cli diff command; I personnally don't think it is a big deal to finally have proper diff output. If you think

Describe the Need

Any ruby user depending on chef-cli is currently blocked on old buggy deps :(

Current Alternative

Different Gemfile ... yeah! 👎🏻

Can We Help You Implement This?

I can submit a PR to remove the constraints, but you may want a Breaking change release, I don't know, let me know!

[Annih]

Ahah @nikhil2611 I see you are working on a major version release, do you think we could ship such "breaking" change?

[nikhil2611]

Hey @Annih , I've updated the diff-lcs dependency to ">= 1.2.4", "!= 1.4.0", "< 1.6.0" and tested most of the chef diff commands. I didn't encounter any breaking changes.

Branch: chef-cli-5

[Annih]

@nikhil2611 Thanks! Have you been able to test with 1.6.1? it includes lots of changes that I made to make diff-lcs more like diff. These changes might appear like "breaking", but I think it could be interesting to just remove the constraint in chef-cli's gemspec, as it prevents people using up-to-date gems.

[nikhil2611]

Yeah sure @Annih, We’ll consider that and test with v1.6.1 as well. However, for now, we need to proceed with this release since we have diff-lcs < 1.6 dependencies on other packages also.