chargebee-ruby icon indicating copy to clipboard operation
chargebee-ruby copied to clipboard

Bump rest-client to 2.1.0

Open loomchild opened this issue 1 year ago • 4 comments

Allow rest-client dependency 2.1.0.

Closes #55

Related to #43 and #50

loomchild avatar Sep 08 '24 12:09 loomchild

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

sonarqubecloud[bot] avatar Sep 08 '24 18:09 sonarqubecloud[bot]

Please advise what to do with the above warning (I don't have access to detailed message, so it's not clear to me what is wrong)

loomchild avatar Sep 08 '24 19:09 loomchild

@cb-alish Please let me know if you need anything else regarding this patch (e.g. supporting deflate, reformating code, etc.)

loomchild avatar Oct 03 '24 09:10 loomchild

Hi @loomchild, my apologies for the delay in response. We'll look into this and come back with any questions / required changes later this. Thanks for your patience.

cb-sriramthiagarajan avatar Oct 14 '24 15:10 cb-sriramthiagarajan

Hi @loomchild (and others watching this), we're still looking into this and get back soon.

While we're testing this, one of the approaches that we're thinking is to get rid of rest-client entirely in favour of using Net::HTTP to keep things simple. If you have any feedback on this, please do share. Thanks.

cb-sriramthiagarajan avatar Oct 18 '24 10:10 cb-sriramthiagarajan

Hi @loomchild, could you take a look at #85 when you have a moment? We're transitioning to Net::HTTP with the goal of removing rest-client as a dependency. Just want to make sure everything looks good from your side. Thanks!

cb-alish avatar Nov 05 '24 06:11 cb-alish

I found an alternative solution, so I am no longer waiting for this PR. Unfortunately, I won't find the time right now to test your new solution. Feel free to drop it if it's no longer useful.

loomchild avatar Nov 05 '24 08:11 loomchild