chargebee-ruby icon indicating copy to clipboard operation
chargebee-ruby copied to clipboard

Timeout errors are not properly detected

Open jablan opened this issue 3 years ago • 0 comments

At least some timeout errors do not have valid JSON, and although their body contains the reason they end up here https://github.com/chargebee/chargebee-ruby/blob/master/lib/chargebee/rest.rb#L82 resulting with a generic error. Also, rest.rb has JSON parsing on two places, which should be unified.

A/C: Properly handle timeout errors and eventually use this code for them: https://github.com/chargebee/chargebee-ruby/blob/master/lib/chargebee/rest.rb#L65

Bonus points: create different exception types for different failure reasons.

jablan avatar Dec 12 '22 08:12 jablan