chargebee-ruby icon indicating copy to clipboard operation
chargebee-ruby copied to clipboard

Use the latest version of rest-client (why a downgrade!?)

Open collimarco opened this issue 4 years ago • 11 comments

Hello,

Why is there a downgrade of the rest-client gem? Your commit message is empty...

Please clarify the motivation and fix this in order to use the latest version. It is important to use always the latest gem version to avoid bugs and security issues.

collimarco avatar Jun 24 '21 13:06 collimarco

The deprecation has been done to support backward compatibility. We are working on upgrading to the latest version of rest-client in the further releases.

cb-rakesh avatar Jul 22 '21 05:07 cb-rakesh

Hi there is there any news on this? It's preventing upgrades to other critical gems that require rest_client >= 2.1

ActualAl avatar Apr 11 '22 14:04 ActualAl

Any updates on this?

jfloff avatar Jan 19 '24 20:01 jfloff

Bump

callahat avatar Apr 03 '24 20:04 callahat

Any updates on this? @cb-khushbubibay @cb-rakesh

DevStarks avatar Jul 29 '24 19:07 DevStarks

@cb-alish Could you please look into this and clarify why the old version of rest-client is needed (sorry to mentioning you directly, but you seem to be the last person who committed to this repo).

loomchild avatar Aug 27 '24 08:08 loomchild

Hi @loomchild, It seems to have some compatibility issues. Specifically, the rest_client version 2.1.0 includes breaking changes. Please refer to #43 & #50 once.

cb-alish avatar Aug 27 '24 09:08 cb-alish

Ah, it makes sense, thank you very much for the information. I will investigate what to do (since I also have a conflict with another gem requiring 2.1.0).

loomchild avatar Aug 27 '24 09:08 loomchild

@cb-alish The breaking change seems to be located in https://github.com/rest-client/rest-client/pull/597 and there's a workaround described in https://github.com/rest-client/rest-client/issues/740#issuecomment-778254696. Would you consider implementing it (looks like the change is located only in rest.rb file).

If not, would you potentially accept a PR implementing it? (I would need help in testing the use cases reported in PRs you linked, but can give it a try).

loomchild avatar Sep 03 '24 17:09 loomchild

Hi @loomchild, sure we'll consider implementing it but it might take a few weeks before we can get to this.

If you'd like to contribute, please create a PR and we can definitely test & include it in the SDK.

cb-alish avatar Sep 04 '24 05:09 cb-alish

I had some ideas what could be the issue and how to solve it based on https://github.com/rest-client/rest-client/issues/722. But when I have simply tried to bump rest-client to 2.1.0, I was able to retrieve a subscription via (as described in #43):

ChargeBee::Subscription.retrieve(subscription_id).subscription

Could you clarify how to reproduce the issues described in #43 and #50? Do I perhaps need to use a specific version of Ruby? (I tested with 3.3.4 and 2.7.8) Maybe Net::HTTP has evolved so the issues no longer occur?

loomchild avatar Sep 08 '24 12:09 loomchild

Hi @callahat & @DevStarks could you take a look at #85 when you have a moment? We're transitioning to Net::HTTP with the goal of removing rest-client as a dependency. Just want to make sure everything looks good from your side. Thanks!

cb-alish avatar Nov 05 '24 06:11 cb-alish

Hi @callahat & @DevStarks! We've released the beta version of the library, now using Net::HTTP and removing rest-client as a dependency. Could you give it a spin in your test environments and share any feedback? Thanks! 🙌

cb-alish avatar Nov 14 '24 12:11 cb-alish

Closing this issue as we've moved from rest-client to native Net::HTTP since v2.49.0. Sorry for the delay in execution. Please feel free to reopen or post in the issue section if you encounter any problems.

cb-alish avatar Jan 31 '25 05:01 cb-alish