chargebee
switch to multi_json
This switches out json_pure for multi_json. json_pure stops some rubyists from utilizing your service because it is incompatible with other json libraries they might be using. This is a drop in replacement and no loss of functionality or speed will occur for existing users. Furthermore, customers using other json libraries like oj will have a marked speed increase.
Also, I added a Gemfile so I could easily install your gems, fixed a broken test and edited a redundant line of code.
Thanks for considering this!
@cb-gaurav sorry to ping you directly but saw you were recently active here. is there any chance the CB team will consider merging this soon? (if the cnoflicts are fixed)
Hey @cb-khushbubibay It seems like you're one of the core maintainers of this repo currently and I realise this PR is really old but would chargebee consider an implementation with multi_json instead of json_pure for the reasons mentioned in the PR body and linked issue? I'd definitely be willing to make a PR based on this off current master if so 🙂 If not I think we should close this PR as well as the linked issue here https://github.com/chargebee/chargebee-ruby/issues/30
Hi @DanielGilchrist Thank you for raising this concern. We sincerely appreciate your input. If it's possible, could you please create a forked repository and raise a pull request with the suggested changes without conflicts. This way, we can check its feasibility and review the modifications.
Hi @DanielGilchrist Thank you for raising this concern. We sincerely appreciate your input. If it's possible, could you please create a forked repository and raise a pull request with the suggested changes without conflicts. This way, we can check its feasibility and review the modifications.
Awesome thank you and no worries! I'll try and find some time next week to get a PR up :)
Closing this as @sobrinho pointed out—we've already moved away from json_pure in v2.52.0.
