chargebee-python icon indicating copy to clipboard operation
chargebee-python copied to clipboard

Fix Exception re-raising in models/events.py

Open kbairak opened this issue 3 years ago • 0 comments

Exceptions do not have message attribute in Python 3.

See PEP-352

Also, and this is my opinion, it doesn't offer any value to re-raise the JSON decode error as something else. I would propose this change too:

-try:
-    webhook_data = json.loads(json_data)
-except (TypeError, ValueError) as ex:
-     raise Exception("The passed json_data is not JSON formatted . {}".format(str(ex)))
+webhook_data = json.loads(json_data)

kbairak avatar Jun 21 '22 08:06 kbairak