chamilo-lms icon indicating copy to clipboard operation
chamilo-lms copied to clipboard

[C2] Delete some components that are not used

Open daniboygg opened this issue 2 years ago • 5 comments

This will remove components that are not in use in Vue application. This will delete some unneeded vuex dependencies.

#5377

daniboygg avatar Apr 17 '24 10:04 daniboygg

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 40.19%. Comparing base (f9eb947) to head (0790826). Report is 223 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5385      +/-   ##
============================================
- Coverage     40.77%   40.19%   -0.59%     
- Complexity    10214    10337     +123     
============================================
  Files           807      818      +11     
  Lines         42433    43470    +1037     
============================================
+ Hits          17304    17473     +169     
- Misses        25129    25997     +868     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 17 '24 10:04 codecov[bot]

I'm not able to review this one, in particular because of the assets/vue/router/course.js removal. I think maybe the corresponding views are a work in progress to be used later. @AngelFQC if these are not works in progress, can we remove them and implement them correctly later on, or should we keep them there to hold the place for the file to be used later?

ywarnier avatar Apr 23 '24 09:04 ywarnier

To clarify my decision, I deleted the file course.js because there was no reference in the code to the routes created in /resources/courses/xxx. The components inside these routes were made with old libraries and didn't work at all.

Because of the routes in https://github.com/chamilo/chamilo-lms/blob/master/assets/vue/router/index.js#L94 I may incorrectly guess that these were the correct ones (/courses , /course/:id/home).

daniboygg avatar Apr 23 '24 09:04 daniboygg

I reverted the changes. So, do we need the components CourseList, CourseUpdate and CourseShow. All of them are using vuex, but when I visit the route I see nothing. I think we should fix these components before remove vuex, otherwise it will be difficult to ensure the behavior is consistent with the old one.

daniboygg avatar Apr 24 '24 12:04 daniboygg

An error occurred when fetching issues.

View more on Code Climate.

qlty-cloud-legacy[bot] avatar Apr 24 '24 12:04 qlty-cloud-legacy[bot]

Tested. I don't see anything missing, feature-wise, by testing it with this PR. Will include soon in master.

ywarnier avatar Jul 03 '24 19:07 ywarnier