ChakraCore icon indicating copy to clipboard operation
ChakraCore copied to clipboard

[CI] +ubuntu22 -ubuntu18

Open ppenzin opened this issue 3 years ago • 5 comments

Drop Ubuntu 18.04 from Azure testing, as it is getting deprecation warnings now (also Canonical stops maintaining software packages after four years, I believe). Add Ubuntu 22.04.

ppenzin avatar Aug 26 '22 23:08 ppenzin

I've built and ran Chakra on Ubuntu 22, though not in the configurations that failed. Investigating.

Update: I can't repro those yet. Have an idea for what might be causing the -Werror issue, but not for the other one. Will re-run.

ppenzin avatar Aug 31 '22 16:08 ppenzin

Now we have the same error in both jobs - it fails to regen bytecode and I'm not yet sure why.

Update: Hm, I thought I habitually ran on Ubuntu 22.04, but it turns out it was 20.04, currently upgrading.

Update 2: Change above fixes the compilation error. I can reproduce bytecode regeneration error, it is a crash. I am going to try to recompile affected files with "passing" flags, if I can isolate them.

ppenzin avatar Sep 01 '22 06:09 ppenzin

This is very strange, is ch crashing completely when regenerating the bytecode?

rhuanjl avatar Sep 10 '22 16:09 rhuanjl

This is very strange, is ch crashing completely when regenerating the bytecode?

Yes. I am trying to narrow that down, there might be something that upsets clang somehow.

ppenzin avatar Sep 12 '22 23:09 ppenzin

As a fun experiment maybe we should build with ToT clang periodically to watch out for errors like this.

ppenzin avatar Sep 17 '22 04:09 ppenzin

This is very strange, is ch crashing completely when regenerating the bytecode?

Yes. I am trying to narrow that down, there might be something that upsets clang somehow.

Cross posting from issue #6847 I think this is because the meaning of auto in some contexts has been changed by an update to C++ - from what I read this was seen as fixing an ambiguity of meaning and hence is applied retroactively whatever standards level you select.

I think we need to reduce/remove the use of auto in the ImmutableList header to fix this.

rhuanjl avatar Oct 10 '22 08:10 rhuanjl

Closing as superseded

rhuanjl avatar Apr 18 '24 13:04 rhuanjl