WhereYouGo icon indicating copy to clipboard operation
WhereYouGo copied to clipboard

Allow opening cartridges from system file browser / apps like WhatsApp

Open JakeDot opened this issue 5 years ago • 7 comments

Is your feature request related to a problem? When I want to play a new cartridge, I have to download it (possible by e.g. opening the wherigo.com link with WhereYouGo), but a downloaded cartridge can not be opened directly from the android file browser with WhereYouGo.

Describe the solution you'd like Allow opening a cartridge from the system storage, either from anywhere by opening it (declaring in AndroidManifest.xml an intent filter for .gwc and .gwz) This would by the way also provide a workaround for the problem that c:geo attempts to open cartridges, even if not solving that it pretends to be able to open any file with the line <data android:mimeType="application/octet-stream" />.

Additional context See cgeo/7663

JakeDot avatar Feb 19 '20 21:02 JakeDot

If someone else wants to have a look at this feel free to reopen PR #40 and push changes there (if that's possible? IDK)

JakeDot avatar Feb 26 '20 18:02 JakeDot

WhereYouGo is not able to import a cartridge using a browser, explorer or other app(tested by modifying a little bit the code from your PR). WhereYouGo can open the cartridge only if you put them into the correct folder and open it in the app by clicking on "Play".

I think WhereYouGo need in app a import function and after that, opening a gwc from a file explorer will work. c:geo or navigation apps can import gpx(or other formats) and so the opening in a file explorer works.

But who need this function? If you manage many cartridges over email or WhatsApp you should be able to putt it after receiving into the correct folder.

hakuchi avatar Feb 27 '20 00:02 hakuchi

Also what needs to be taken care of in such a situation is that you may not be able (or don't want) to write the log files back into the folder where you opened the cartridge from. If WhereYouGo would move the cartridge automatically to its selected storage through "opening" that would indeed be am improvement in my eyes.

SchoolGuy avatar Feb 27 '20 08:02 SchoolGuy

Moving might be unexpected by the user, but maybe copying would be ok. We should decide one fixed behaviour for this functionality before implementing it.

JakeDot avatar Feb 27 '20 11:02 JakeDot

Anyone interested can test my implementation in PR #40 - I think it could still be polished a bit but works for now.

JakeDot avatar Mar 13 '20 08:03 JakeDot

tested with file explorer and works only if the file is in the folder I set in the settings. If I move the cartridge to a other folder it is impossible to play

hakuchi avatar Mar 14 '20 01:03 hakuchi

Yes, this is intentional. But the cartridge is correctly saved to the folder in the first place?

I will probably add some messages in the import screen if there is a cartridge with the same filename already, etc.

JakeDot avatar Mar 14 '20 01:03 JakeDot