cernekee
Dockerize
I played around with this a little bit and pushed a couple of small tweaks to the scripts on a branch. As a Docker noob, I'd like to flesh this out a little more before deciding whether to commit to master.
One basic question is: what is the intended use case for running stoken in a Docker container? Is there another project (either active, or under development) that is utilizing stoken in this configuration?
Is the intention to always run stoken (alone) in its own container, or will there be other services/daemons/etc. running in the same container and (say) calling into libstoken to generate tokencodes?
Adding a little context + Docker instructions to the README might be helpful. Ideally the docs would explain when/why this would come in handy, and include a short "cookbook" of commands that a user could copy&paste to get started.
If you don't need stoken-gui, you should be able to safely omit libgtk-3-dev, which I believe pulls in a massive number of dependencies. If you do intend to run stoken-gui from within the container, some trickery might be needed to forward the X11 connections.
make -C docker run executes stoken with no arguments, which may or may not be what you want. Is docker/Makefile a pretty standard wrapper, or would it make sense to just ship the "raw" scripts in this case?
push.sh seems to be missing.
what is the intended use case for running stoken in a Docker container?
Agree, I suspect a flatpak or snap containerized app of stoken/stoken-gui might be more useful.
