go-ceph icon indicating copy to clipboard operation
go-ceph copied to clipboard

cephfs admin: remove test skip in TestCancelClone

Open phlogistonjohn opened this issue 3 years ago • 3 comments

This will re-enable the test case on ceph quincy.

The test does not seem to be reproducing the error on my local machine with the latest quincy image. Making a PR to see if its more related to my system and can still reproduce on the CI or not.

Checklist

  • [ ] Added tests for features and functional changes
  • [ ] Public functions and types are documented
  • [ ] Standard formatting is applied to Go code
  • [ ] Is this a new API? Is this new API marked PREVIEW?

phlogistonjohn avatar May 03 '22 14:05 phlogistonjohn

Interesting: first run in the CI it reproduced the error. See #679 for updated details.

phlogistonjohn avatar May 03 '22 17:05 phlogistonjohn

This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes? 🙏

mergify[bot] avatar Jun 29 '22 13:06 mergify[bot]

This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes? 🙏

mergify[bot] avatar Aug 02 '22 05:08 mergify[bot]

@mergifyio rebase

phlogistonjohn avatar Dec 05 '22 15:12 phlogistonjohn

rebase

✅ Branch has been successfully rebased

mergify[bot] avatar Dec 05 '22 15:12 mergify[bot]

O M G.... It's actually passing!? I guess it's time to clean it up and actually propose this.

phlogistonjohn avatar Dec 05 '22 17:12 phlogistonjohn

I think commit message should mention that it re-enables the test case on both pacific and quincy.

cephfs admin: remove test skip in TestCancelClone

This will re-enable the test case on ceph quincy.

anoopcs9 avatar Dec 06 '22 04:12 anoopcs9

I think commit message should mention that it re-enables the test case on both pacific and quincy.

cephfs admin: remove test skip in TestCancelClone

This will re-enable the test case on ceph quincy.

Done

phlogistonjohn avatar Dec 06 '22 14:12 phlogistonjohn

@mergifyio rebase

phlogistonjohn avatar Dec 06 '22 15:12 phlogistonjohn

rebase

✅ Branch has been successfully rebased

mergify[bot] avatar Dec 06 '22 15:12 mergify[bot]