go-ceph icon indicating copy to clipboard operation
go-ceph copied to clipboard

cephfs/admin: Fix TestCancelClone in quincy and pacific

Open phlogistonjohn opened this issue 3 years ago • 5 comments

In order to merge quincy CI support, the test "TestCancelClone" was disabled on ceph quincy. https://github.com/ceph/go-ceph/blob/e0369cdf88d1418846321ff6a49201dff9eb8514/cephfs/admin/clone_test.go#L147

We need to revisit this test failure and remove the test skip to have the test suite fully operational on quincy.

phlogistonjohn avatar May 02 '22 17:05 phlogistonjohn

=== RUN   TestCancelClone
    clone_test.go:205: 
        	Error Trace:	clone_test.go:205
        	Error:      	Received unexpected error:
        	            	rados: ret=-22, Invalid argument: "Traceback (most recent call last):\n  File \"/usr/share/ceph/mgr/mgr_module.py\", line 1701, in _handle_command\n    return self.handle_command(inbuf, cmd)\n  File \"/usr/share/ceph/mgr/volumes/module.py\", line 409, in handle_command\n    return handler(inbuf, cmd)\n  File \"/usr/share/ceph/mgr/volumes/module.py\", line 38, in wrap\n    return f(self, inbuf, cmd)\n  File \"/usr/share/ceph/mgr/volumes/module.py\", line 636, in _cmd_fs_clone_cancel\n    vol_name=cmd['vol_name'], clone_name=cmd['clone_name'], group_name=cmd.get('group_name', None))\n  File \"/usr/share/ceph/mgr/volumes/fs/volume.py\", line 582, in clone_cancel\n    self.cloner.cancel_job(volname, (clonename, groupname))\n  File \"/usr/share/ceph/mgr/volumes/fs/async_cloner.py\", line 389, in cancel_job\n    with open_subvol(self.fs_client.mgr, fs_handle, self.vc.volspec, group, clonename, SubvolumeOpType.CLONE_CANCEL) as clone_subvolume:\n  File \"/usr/lib64/python3.6/contextlib.py\", line 81, in __enter__\n    return next(self.gen)\n  File \"/usr/share/ceph/mgr/volumes/fs/operations/subvolume.py\", line 72, in open_subvol\n    subvolume = loaded_subvolumes.get_subvolume_object(mgr, fs, vol_spec, group, subvolname)\n  File \"/usr/share/ceph/mgr/volumes/fs/operations/versions/__init__.py\", line 95, in get_subvolume_object\n    subvolume.discover()\n  File \"/usr/share/ceph/mgr/volumes/fs/operations/versions/subvolume_base.py\", line 319, in discover\n    self.metadata_mgr.refresh()\n  File \"/usr/share/ceph/mgr/volumes/fs/operations/versions/metadata_manager.py\", line 52, in refresh\n    self.config.readfp(conf_data)\n  File \"/usr/lib64/python3.6/configparser.py\", line 763, in readfp\n    self.read_file(fp, source=filename)\n  File \"/usr/lib64/python3.6/configparser.py\", line 718, in read_file\n    self._read(f, source)\n  File \"/usr/lib64/python3.6/configparser.py\", line 1111, in _read\n    raise e\nconfigparser.ParsingError: Source contains parsing errors: '<???>'\n\t[line 13]: 'a0\\n'\n"
        	            	

phlogistonjohn avatar May 03 '22 17:05 phlogistonjohn

I filed https://tracker.ceph.com/issues/55583 to see if we can get some feedback from the cephfs team on this.

phlogistonjohn avatar May 09 '22 19:05 phlogistonjohn

adjusted issue title to reflect that it needs to be fixed(and further revert the skip) for quincy and pacific.

anoopcs9 avatar Jul 06 '22 12:07 anoopcs9

The fix for the issues has been merged into ceph's main branch. Hopefully the backports will land soon too.

phlogistonjohn avatar Aug 15 '22 13:08 phlogistonjohn

Backport PRs:

  • https://github.com/ceph/ceph/pull/47747
  • https://github.com/ceph/ceph/pull/47748

phlogistonjohn avatar Aug 23 '22 13:08 phlogistonjohn

new backport batch pr for pacific:

  • https://github.com/ceph/ceph/pull/47112

phlogistonjohn avatar Sep 27 '22 14:09 phlogistonjohn