ceph icon indicating copy to clipboard operation
ceph copied to clipboard

reef: cephadm: use importlib.metadata for querying ceph_iscsi's version

Open zdover23 opened this issue 1 year ago • 4 comments

use importlib.metadata for querying ceph_iscsi's version and fallback to pkg_resources. as the former is only available in Python 3.8, while the latter is deprecated.

Refs https://tracker.ceph.com/issues/66201

This commit is functionally equivalent to a Reef-targeted backport of https://github.com/ceph/ceph/pull/57685.

Contribution Guidelines

  • To sign and title your commits, please refer to Submitting Patches to Ceph.

  • If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.

  • When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an x between the brackets: [x]. Spaces and capitalization matter when checking off items this way.

Checklist

  • Tracker (select at least one)
    • [x] References tracker ticket
    • [ ] Very recent bug; references commit where it was introduced
    • [ ] New feature (ticket optional)
    • [ ] Doc update (no ticket needed)
    • [ ] Code cleanup (no ticket needed)
  • Component impact
    • [ ] Affects Dashboard, opened tracker ticket
    • [x] Affects Orchestrator, opened tracker ticket
    • [ ] No impact that needs to be tracked
  • Documentation (select at least one)
    • [ ] Updates relevant documentation
    • [x] No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

zdover23 avatar Jun 27 '24 18:06 zdover23

From what I can tell recent pushes have just been changing the formatting, so as long as make check passes this LGTM

Thanks, @adk3798. I'm just learning (at the feet of the extremely patient Josh) about how very finicky Python can be in connection to whitespace. I hope that all my... uh... mucking about... hasn't been too much of an inconvenience. Thanks for your forbearance.

zdover23 avatar Jun 28 '24 18:06 zdover23

jenkins retest this please

zdover23 avatar Jun 29 '24 17:06 zdover23

jenkins test make check

zdover23 avatar Jun 30 '24 18:06 zdover23

jenkins test make check

zdover23 avatar Jul 05 '24 19:07 zdover23

jenkins test api

zdover23 avatar Jul 07 '24 00:07 zdover23

jenkins test api

zdover23 avatar Jul 15 '24 15:07 zdover23