ceph icon indicating copy to clipboard operation
ceph copied to clipboard

crimson/osd: add the delete-head special case of CEPH_OSD_OP_ROLLBACK

Open rzarzynski opened this issue 3 years ago • 1 comments

This allows to pass TestLibRBD.TestIOToSnapshot:

[rzarzynski@o06 build]$ CRIMSON_COMPAT=true RBD_FEATURES=1 bin/ceph_test_librbd --gtest_filter=TestLibRBD.TestIOToSnapshot
seed 3954016
Note: Google Test filter = TestLibRBD.TestIOToSnapshot
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from TestLibRBD
[ RUN      ] TestLibRBD.TestIOToSnapshot
using new format!
...
opening testimg@orig
read: 80
write to snapshot returned -30
Read-only file system
num snaps is: 2
expected: 2
snap: orig
snap: written
found orig with size 2097152
found written with size 2097152
num snaps is: 1
expected: 1
snap: orig
found orig with size 2097152
num snaps is: 0
expected: 0
[       OK ] TestLibRBD.TestIOToSnapshot (7510 ms)
[----------] 1 test from TestLibRBD (7510 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (8504 ms total)
[  PASSED  ] 1 test.

Signed-off-by: Radoslaw Zarzynski [email protected]

Contribution Guidelines

Checklist

  • Tracker (select at least one)
    • [ ] References tracker ticket
    • [ ] Very recent bug; references commit where it was introduced
    • [ ] New feature (ticket optional)
    • [ ] Doc update (no ticket needed)
    • [ ] Code cleanup (no ticket needed)
  • Component impact
    • [ ] Affects Dashboard, opened tracker ticket
    • [ ] Affects Orchestrator, opened tracker ticket
    • [ ] No impact that needs to be tracked
  • Documentation (select at least one)
    • [ ] Updates relevant documentation
    • [ ] No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows

rzarzynski avatar Oct 13 '22 12:10 rzarzynski

/home/jenkins-build/build/workspace/ceph-pull-requests/src/crimson/osd/pg_backend.cc:722:30: error: lambda capture 'this' is not used [-Werror,-Wunused-lambda-capture] ).safe_then_interruptible([this](auto ref) {

athanatos avatar Oct 13 '22 20:10 athanatos

/home/jenkins-build/build/workspace/ceph-pull-requests/src/crimson/osd/pg_backend.cc:802:30: error: lambda capture 'this' is not used [-Werror,-Wunused-lambda-capture]

Matan-B avatar Oct 20 '22 07:10 Matan-B

Introduced the rollback_ertr and fixed lambda capture. Thanks for pointing it out!

rzarzynski avatar Oct 20 '22 13:10 rzarzynski

jenkins test api

rzarzynski avatar Oct 20 '22 14:10 rzarzynski