enh(as400): mode page-faults add option --units

[garnier-quentin]

Community contributors

Description

Right now, the mode provides metrics in absolute percentage. We add an option to have: percent, percent_delta, delta, counter.

CTOR-1464

Type of change

• [ ] Patch fixing an issue (non-breaking change)
• [ ] New functionality (non-breaking change)
• [X] Functionality enhancement or optimization (non-breaking change)
• [ ] Breaking change (patch or feature) that might cause side effects breaking part of the Software

How this pull request can be tested ?

$ perl centreon_plugins.pl --plugin=os::as400::connector::plugin --mode=page-faults --as400-hostname=127.0.0.1 --as400-username=xxxx --as400-password=yyy --verbose --units=counter
OK: database page faults: 0.00% (0 on 200), nondatabase page faults: 3.33% (5 on 150) | 'pagefaults.database.ratio.count'=0;;;0;200 'pagefaults.nondatabase.ratio.count'=5;;;0;150

Checklist

• [X] I have followed the coding style guidelines provided by Centreon
• [ ] I have commented my code, especially hard-to-understand areas of the PR.
• [ ] I have rebased my development branch on the base branch (develop).
• [ ] I have provide data or shown output displaying the result of this code in the plugin area concerned.

[Evan-Adam]

Hello @garnier-quentin I see this modification don't allow to show the 4 metrics in the same execution. could it be possible instead to add all these new perfdata, and the users can hide them if necessary with the generic options of counter.pm ? Can also you provide debug for this plugin execution ? This will allow to make automated test in the future on this plugin.

Have a good day. Evan