centreon-plugins icon indicating copy to clipboard operation
centreon-plugins copied to clipboard
verified publisher icon centreon

Update volumes.pm: add ex4100 support

Open joschi99 opened this issue 2 years ago • 4 comments

#4804

Description

PLEASE MAKE SURE THAT THE BRANCH PR INCLUDES JIRA TICKET ID (for centreon-internal)

Please include a short resume of the changes and what is the purpose of PR. Any relevant information should be added to help:

  • QA Team (Quality Assurance) with tests.
  • reviewers to understand what are the stakes of the pull request.

Fixes # (issue)

Type of change

  • [ ] Patch fixing an issue (non-breaking change)
  • [ ] New functionality (non-breaking change)
  • [ ] Breaking change (patch or feature) that might cause side effects breaking part of the Software

Target serie

  • [ ] 22.04.x
  • [ ] 22.10.x
  • [ ] 23.04.x
  • [ ] 23.10.x
  • [ ] 24.04.x (master)

How this pull request can be tested ?

Please describe the procedure to verify that the goal of the PR is matched. Provide clear instructions so that it can be correctly tested.

Any relevant details of the configuration to perform the test should be added.

Checklist

Community contributors & Centreon team

  • [ ] I have followed the coding style guidelines provided by Centreon
  • [ ] I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • [ ] I have commented my code, especially hard-to-understand areas of the PR.
  • [ ] I have rebased my development branch on the base branch (master, maintenance).

joschi99 avatar Jan 04 '24 18:01 joschi99

Hi @omercier, did you evaluate this pull requests to add support for ex4100? We have done tests and it works fine

joschi99 avatar Feb 20 '24 06:02 joschi99

Hi @joschi99, No, not yet, sorry.

omercier avatar Feb 20 '24 22:02 omercier

Hi @joschi99,

Thanks for the contribution :100: Your contribution will be discussed during the next weekly sessions of refinement with the team alongside with #4806 and #4805 Thanks :+1:

Regards,

omercier avatar Mar 04 '24 17:03 omercier

Hello :)

Thanks for the contribution 🙏 To help us integrate it can you provide some data test to help us for adding automated test on it? (an snmpwalk or only the part of it that allows testing it)

lucie-tirand avatar Jun 24 '24 16:06 lucie-tirand

Hello :)

This PR and the two others about this plugin are currently waiting to have the data (snmpwalk) concerning the volume mode in order to be able to generate the associated automated tests.

lucie-tirand avatar Jul 04 '24 15:07 lucie-tirand

Here you can find a full snmp walk nas-wd.txt

joschi99 avatar Jul 05 '24 05:07 joschi99