opencensus-python icon indicating copy to clipboard operation
opencensus-python copied to clipboard

GRPC client interceptor: check if response has exception before trying to access result

Open AmicoJoules opened this issue 5 years ago • 3 comments

Small fix on the callback set by the grpc client interceptor. Trying to access the result raises the Future exception which can be problematic for asynchronous grpc calls.

This PR addresses issue https://github.com/census-instrumentation/opencensus-python/issues/790

AmicoJoules avatar Aug 26 '20 19:08 AmicoJoules

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

googlebot avatar Aug 26 '20 19:08 googlebot

@googlebot I fixed it.

AmicoJoules avatar Aug 26 '20 19:08 AmicoJoules

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot avatar Aug 26 '20 19:08 googlebot