opencensus-python icon indicating copy to clipboard operation
opencensus-python copied to clipboard

Check disabled tracing URLs based on regex

Open jonasmiederer opened this issue 3 years ago • 2 comments

Currently the disabled tracing URLs are checked by testing whether the path starts with one of the provided excludelist paths

However if I want to exclude the root (/) from being traced, this is not possible. If an empty string is provided to disable_tracing_url, every path is disabled as every string starts with an empty string.

'ui'.startswith('')
True

A check using regex would solve the problem and also make it more flexible.

jonasmiederer avatar Mar 02 '22 14:03 jonasmiederer

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

google-cla[bot] avatar Mar 02 '22 14:03 google-cla[bot]

Is this change going to be released? I would like to exclude the root requests that an Azure App Service sends for "Always On".

tcihak-fqa avatar Sep 29 '22 20:09 tcihak-fqa