Remove @ts-expect-error comments from TS 3.x migration

Open aabmass opened this issue 4 years ago • 2 comments

I used the ts-migrate script to add @ts-expect-error to silence new TS errors introduced in migration from TypeScript 2.x to 3.x (#907). For example https://github.com/census-instrumentation/opencensus-node/blob/9bd4f114cc3c18f148a2f56392db5e393cb968ab/packages/opencensus-core/src/internal/cls-ah.ts#L95

Definitive list: https://github.com/census-instrumentation/opencensus-node/search?q=ts-migrate

Jul 19 '21 18:07 aabmass

There are more than 20 such comments. Do you want all of them removed?

Oct 05 '21 06:10 alaminShaheen

Yes if possible, but it's low priority as this project has been mostly superseded by OpenTelemetry 🙂 Would you like to help out on this?

Oct 14 '21 15:10 aabmass