Add support for nested spans

Open kenashcraft opened this issue 6 years ago • 2 comments

rootSpan.startChildSpan() takes an options object as input where one of the fields is parentSpanId. However, parentSpanId isn't wired up. This PR does that wiring and adds tests for both the core library as well as the Zipkin exporter.

Fixes #105

Mar 20 '19 20:03 kenashcraft

I'm changing opencensus-core and opencensus-exporter-zipkin simultaneously. opencensus-exporter-zipkin specifies a published version of opencensus-core. Is this expected to work or should it be split into two PRs?

Mar 20 '19 20:03 kenashcraft

Thanks for the contribution BTW! I have been thinking about this type of functionality and see https://github.com/census-instrumentation/opencensus-node/issues/105 for more

Mar 20 '19 20:03 draffensperger