celestia-node icon indicating copy to clipboard operation
celestia-node copied to clipboard

Inconsistency in casing in node RPC responses

Open zvolin opened this issue 2 years ago • 1 comments

Celestia Node version

6654cdf

OS

Archlinux 6.3.6-zen

Install tools

docker

Others

No response

Steps to reproduce it

Based mostly on the API documentation: https://node-rpc-docs.celestia.org/#p2p Most of the API responses use snake_case fields naming convention, however whole P2P module, SyncState response and GetSharesByNamespace response use PascalCase naming.

Expected result

Uniform naming conventions for all the API surface

Actual result

Some methods use PascalCase naming of fields

Relevant log output

Example GetSharesByNamespace response:

[{
    "Shares":[
        "AAAAAAAAAAAAAAAAAAAAAAAAAE3BWIMKXpgB8QMBAAAEAP////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////8="
    ],
    "Proof":{}
}]

zvolin avatar Jul 03 '23 17:07 zvolin

Hello @zvolin. Thanks for creating an issue.

vgonkivs avatar Jul 11 '23 09:07 vgonkivs