celestia-node icon indicating copy to clipboard operation
celestia-node copied to clipboard

feat(share): EDSStore scaffolding

Open distractedm1nd opened this issue 3 years ago • 1 comments

Based on top of #1158, replaces #1051

Closes #1107 Closes #1108 Closes #1115 Closes #1110 Closes #1111 Closes #1112

Would recommend that I open a feature branch for this, and merge into there. This is the scaffolding, but work is very much still required:

[ ] Write tests [ ] Check if EDSStore.Blockstore has parity with the new default impl's Blockstore [ ] Add logging

distractedm1nd avatar Oct 14 '22 08:10 distractedm1nd

Codecov Report

Merging #1232 (8ce9631) into main (f8bef40) will decrease coverage by 0.30%. The diff coverage is 55.00%.

@@            Coverage Diff             @@
##             main    #1232      +/-   ##
==========================================
- Coverage   55.42%   55.12%   -0.31%     
==========================================
  Files         178      180       +2     
  Lines       10746    10890     +144     
==========================================
+ Hits         5956     6003      +47     
- Misses       4211     4288      +77     
- Partials      579      599      +20     
Impacted Files Coverage Δ
nodebuilder/share/service.go 100.00% <ø> (ø)
share/eds/retriever.go 93.71% <ø> (ø)
share/eds/store.go 52.80% <52.80%> (ø)
libs/utils/address.go 59.09% <59.09%> (ø)
nodebuilder/gateway/config.go 68.42% <66.66%> (+5.92%) :arrow_up:
nodebuilder/rpc/config.go 66.66% <66.66%> (+6.66%) :arrow_up:
nodebuilder/core/config.go 57.14% <100.00%> (-5.36%) :arrow_down:
nodebuilder/core/opts.go 0.00% <0.00%> (-50.00%) :arrow_down:
nodebuilder/das/daser.go 75.00% <0.00%> (-25.00%) :arrow_down:
header/core/listener.go 52.83% <0.00%> (-5.67%) :arrow_down:
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Oct 14 '22 08:10 codecov-commenter

Removed blockstore so it can go into a new PR and can be reviewed more thoroughly, this PR is too big rn and the main part of it can get merged

distractedm1nd avatar Nov 21 '22 09:11 distractedm1nd