ceejbot
Do not limit user to use payload job attribute
why are we restricting user from using his own custom attribute to define the payload/message The queue can be used for sending messages/jobs/notification. I feel we should not put any restriction on the attributes of the job payload, make available the entire data/payload which a user puts in the queue
Coverage remained the same at 93.017% when pulling 22257bacdd02b0c59631d320351d9e77aff4e374 on sandeep89:master into 70f1e7d5e171d4a2189204ff30ad641d2b371229 on ceejbot:master.
Coverage remained the same at 93.017% when pulling c75862f3d5ec496fd09367e718192c2b7db6ad5a on sandeep89:master into 70f1e7d5e171d4a2189204ff30ad641d2b371229 on ceejbot:master.
@ceejbot you have to help me here, when I try to run the testcases locally for v0.10 it runs without error :( not sure why it fails on travis. And this looks to be important for me, it would be of great help if you look into it.
Intermittent failure on node 0.10 only-- one specific test times out sometimes. This isn't a real failure, but it's a PITA for sure.
So, this restriction was here initially for compatibility with a Ruby-ecosystem beanstalk library. I'm not sure who it would break to change this behavior. It would have to be a major-number bump.
@ceejbot added support for default payload key and give option to user for not force it. Let me know if this helps us
Coverage increased (+0.06%) to 93.075% when pulling 8c5301302da98d403f6cc6e042b261b529446abf on sandeep89:master into 70f1e7d5e171d4a2189204ff30ad641d2b371229 on ceejbot:master.
Coverage increased (+0.06%) to 93.075% when pulling 3bf598234e0422feecd91766ba4a0ea2c543e0ee on sandeep89:master into 70f1e7d5e171d4a2189204ff30ad641d2b371229 on ceejbot:master.
@ceejbot Please check and do let me know if we can go ahead with this merge