Sam Cedarbaum

Results 17 comments of Sam Cedarbaum

Thanks for the review! I think I did find a design issue with this current approach unfortunately. It occurred to me that this current logic assumes that the static feed...

After giving this some more thought, I think the easiest (though perhaps not most elegant) way to handle this is to just add a feed config option for whether to...

I ran into this as well - a couple potential solutions: 1. Don't parse CLI flags when `EF.IsDsignTime` is `true`. This only works if you don't need the CLI flags...

@olstakh sounds like this would work! I think the only potential downside is if you always set this, you might miss some invalid flags in other cases (e.g., when a...

Also @jamespfennell FYI, I think something in CI has been broken recently. I haven't had a chance to look, but things do pass locally. If you have any ideas LMK...

Thanks for fixing the CI! And it definitely makes sense to do this in the GTFS library, good call! I've opened a PR there to handle this: https://github.com/jamespfennell/gtfs/pull/18 I can...

I've updated this PR to just surface alerts that explicitly inform a `trip_id`. This does leave some additional work to also try and match informed trips without an explicit `trip_id`...