php-openapi icon indicating copy to clipboard operation
php-openapi copied to clipboard

Allow Symfony 7

Open tacman opened this issue 2 years ago • 1 comments

tacman avatar Feb 05 '24 14:02 tacman

any downside to merging this?

tacman avatar Jun 25 '24 17:06 tacman

Tests are failing on php 8.2 https://github.com/cebe/php-openapi/pull/212

cebe avatar Nov 13 '24 16:11 cebe

yes, but that's not related to Symfony 7, is it?

tacman avatar Nov 13 '24 22:11 tacman

Personally, I'd prefer to see all unsupported versions of Symfony dropped. So ^5.4, ^6.4, ^7

If it's a new release, I'd even say just ^6.4 || ^7, since 5.4 is near EOL

tacman avatar Nov 13 '24 22:11 tacman

yes, but that's not related to Symfony 7, is it?

I did not know whether it's related or not so I wanted to wait for tests to pass.

Personally, I'd prefer to see all unsupported versions of Symfony dropped. So ^5.4, ^6.4, ^7

what's the point in dropping versions that work fine, breaking someones code? Dropping old versions is fine if it is complicated to support these. For Symfony YAML I'd keep it as widely compatibly as possible.

cebe avatar Nov 14 '24 21:11 cebe

Your commit is merged in #212, thanks!

cebe avatar Nov 14 '24 21:11 cebe

@cebe: I suppose, brach merged but a new version 7.1 release is pending.

prajapati-kaushik avatar Dec 23 '24 15:12 prajapati-kaushik