cdap icon indicating copy to clipboard operation
cdap copied to clipboard

Fixes css class name added to connection to use node id instead of node name

Open ajainarayanan opened this issue 4 years ago • 1 comments

Problem

  • We switched to using node id for a plugin in DOM while rendering nodes and connections
  • But we missed out on replacing node id in css classes being applied to connections.
  • This caused problems in corner cases where the stage names had spaces and css class based names, eg: table.
  • This plugin name with spaces and common names like table in class in the DOM node caused browser to render additional styles that we define under table css class which causes unnecessary deformation in connections. Screen Shot 2021-03-19 at 10 01 47 PM

Fix

  • Fix css class for connections to use node id instead of node name.

ajainarayanan avatar Mar 20 '21 05:03 ajainarayanan

gitpod-io[bot] avatar Mar 20 '21 05:03 gitpod-io[bot]