cdap icon indicating copy to clipboard operation
cdap copied to clipboard

Quick mod to kms client to attempt checking for keyring existence before attempting creation

Open jbharter opened this issue 5 years ago • 3 comments

Where we currently don't want to grant the running service account full keyring creation permission on the project, we propose a change to first check for existence of the specified keyring. This means that the authenticating account for kms needs only permissions to modify the keyring it is given, and not the permission to create keyrings themselves.

jbharter avatar Dec 17 '20 01:12 jbharter

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

google-cla[bot] avatar Dec 17 '20 01:12 google-cla[bot]

@googlebot I signed it!

jbharter avatar Dec 17 '20 01:12 jbharter

Would you mind opening a JIRA at https://cdap.atlassian.net/browse/CDAP as well?

chtyim avatar Dec 18 '20 22:12 chtyim

Closing old PRs

aviachar avatar May 12 '23 16:05 aviachar