cdap-operator icon indicating copy to clipboard operation
cdap-operator copied to clipboard

CDAP-19300 adding container injection feature and Dockerfile for unit testing on Docker image

Open mariogiuffrida opened this issue 3 years ago • 4 comments

This change refers to the ticket CDAP-19300 - https://cdap.atlassian.net/browse/CDAP-19300.

In this change, we introduced:

  • the possibility of injecting containers inside Stateful and Deployment services.
  • the possibility to override the service ports (i.e. router listening on non-default ports)
  • a new Dockerfile.test specifically used to run unit test on a Docker image

mariogiuffrida avatar May 18 '22 09:05 mariogiuffrida

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

google-cla[bot] avatar May 18 '22 09:05 google-cla[bot]

Thank you @dli357 I have now uploaded a new commit version

mariogiuffrida avatar Jul 14 '22 16:07 mariogiuffrida

Thank you for all your great feedback @arjan-bal! I have now uploaded a new commit version.

mariogiuffrida avatar Sep 12 '22 17:09 mariogiuffrida

@arjan-bal @dli357 I have uploaded a new version which considers all your comments (thank you). Could you please review it?

mariogiuffrida avatar Nov 17 '22 11:11 mariogiuffrida