Christopher Dancy
Christopher Dancy
Does Bitbucket provide this feature or Communardo?
@krasv apologies for getting back so late. Been busy with work. I don't want anything provider specific within this library. Developers are free to fork this project however and add...
@padas2 will do. Was out sick yesterday and planned on looking at things and providing comments end-of-day today.
Looking things over we'll need mock-tests to cover both endpoints. Also ... both endpoints, and the objects they return, NEED to handle failure states with the `error` objects that are...
``` There is code duplication in 2 classes i.e. SupportZipDetails and SupportZipStatus. Tried using the HAS-A pattern to include SupportZipDetails in SupportZipStatus class itself but looks like it is not...
Also ... for downloading the zip lets leave that for a subsequent PR. I generally like to have 1 endpoint per PR to make things easier for reviewing.
> On trying to determine the status of the support Zip task id, this is the response we get. Ok they look very similar. Lets go with creating just the...
@padas2 sounds good!
@padas2 would those be different endpoints or included in the response of the existing endpoints in this PR?
Also ... PR looks good so far. Still need another pass through to implement `ErrorsHolder` on the `SupportZip` domain object. Take a look at the `RequestStatus` below for a simple...