es6-tutorial icon indicating copy to clipboard operation
es6-tutorial copied to clipboard

404 issue when uploading to GitHub Pages, due to error in node modules (maybe add node_modules to .gitignore file?)

Open TommyJackson85 opened this issue 7 years ago • 0 comments

When I try to upload the project to GitHub Pages, I get a 404 error when loading the index file, followed by an email from GitHub:

The page build failed for the master branch with the following error: The variable {{a} on line 50 in node_modules/balanced-match/README.md was not properly closed with }}. For more information, see https://help.github.com/articles/page-build-failed-tag-not-properly-terminated/. For information on troubleshooting Jekyll see: https://help.github.com/articles/troubleshooting-jekyll-builds If you have any questions you can contact us by replying to this email

I managed to fix this error after reading up on the following links. This is a common problem with Jekyll: https://github.com/juliangruber/balanced-match/issues/22 https://github.com/EarthlingInteractive/aframe-geo-projection-component/commit/f06ab2e725b33073f9cd99a4278bd35985c4545a

I fixed the error by changing the .gitignore file to the following, (BEFORE uploading it as a new repository to GitHub):

node_modules/*
.idea/

may I suggest changing the .gitignore file, or to highlight this issue in the ES6-Tutorial instructions, incase someone else wants to upload it to GitHub pages. edit: If the repository is already uploaded with node_modules you could untrack node_modules with the following git command at the repository folder: git rm --cached node_modules -r

TommyJackson85 avatar May 21 '18 12:05 TommyJackson85