Christian Clauss

Results 1723 comments of Christian Clauss

Please fix the conflicts or close.

Please fix the conflicts or close.

tests/test_rtrip.py seems to fail for me on Python 3 in #208

Is it rocket science too fix this stuff?

Perhaps your test cases do not execute the lines in question. If those lines are executed, they will throw the exceptions indicated.

flake8 testing of https://github.com/dchrastil/ScrapedIn on Python 3.9.0rc1+ flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics ``` ./ScrapedIn.py:84:11: E999 SyntaxError: invalid syntax print "[Info] %i Results Found" % data_total ^ 1 E999 SyntaxError:...

At least one of your param lines is missing an required equal sign (=)... ``` A=Al B=Bob C=Carl DDavid # This line is missing an equal sign (=) ``` Also,...

Is Google style like https://github.com/internetarchive/openlibrary/issues/6755 ? * https://google.github.io/styleguide/pyguide.html#383-functions-and-methods has shifted to type hints.

You understand well -- I too am torn about how to implement this but I tend to put the ___fastest___ checks in pre-commit and the slower checks in a separate...