cce
cce
Closing in favor of #4777
I think there may be tests that use GenerateBlock and want the deltas, which is why I left GenerateBlock as is but changed only the return type of AssembleBlock.. I...
Looking at it now I'm not sure it's essential to modify the return type of `BlockEvaluator.GenerateBlock()`. Hiding the `BlockEvaluator`, dropping the deltas, and returning an `agreement.AssembledBlock` is the job of...
My point is that agreement controls the only way for validated blocks to get added to the ledger when calling agreement.EnsureValidatedBlock — which this PR addresses (just the types handled...
Closing, merged into https://github.com/algorand/go-algorand/pull/5757 via https://github.com/jannotti/go-algorand/pull/19
Closing, replaced by #5973 and what has already been merged into #5757 via jannotti/go-algorand#19
Closing for now; can revisit later after other networking changes are completed
This was helpful but no longer needed
We use the binary protocol because it seemed easier than worrying about ASCII-encoding binary keys like hashes or UTF-8 strings, and seemed faster as well for the reasons you mentioned....
So the panic is here https://github.com/algorand/go-algorand/blob/9fc615830193f3fb4f0e527ca94871048021104d/util/execpool/pool.go#L161-L163 And the channel close is here: https://github.com/algorand/go-algorand/blob/9fc615830193f3fb4f0e527ca94871048021104d/agreement/asyncVoteVerifier.go#L179-L188 Shouldn't the backlogExecPool.Shutdown() wait until the underlying pool worker shuts down before returning to AsyncVoteVerifier.Quit() and letting...