Casey Bodley
Casey Bodley
@cfsnyder @ormandj it's approved, just needs qa. i'll try get a batch through today
passed qa in https://pulpito.ceph.com/cbodley-2022-09-30_16:47:21-rgw-wip-cbodley-testing-distro-default-smithi/
i pushed the 'variadic template to std::array' version, and it simplified the algorithm a lot. i really didn't like its syntax though - it couldn't deduce `{"a","b"}` arguments, so you...
jenkins test api
thanks @mkogan1, i'm looking through the results and see lots of crashes on startup in the centos jobs: ``` 2022-08-16T21:36:41.409 INFO:tasks.rgw.client.0.smithi165.stdout:terminate called after throwing an instance of 'std::bad_variant_access' 2022-08-16T21:36:41.410 INFO:tasks.rgw.client.0.smithi165.stdout:...
i'm seeing the same crashes in another branches too, so it's not caused by this pr. http://qa-proxy.ceph.com/teuthology/cbodley-2022-08-18_23:33:15-rgw-wip-cbodley-testing-distro-default-smithi/6979641/teuthology.log
i opened https://tracker.ceph.com/issues/57195 to track that crash. because it isn't caused by this PR, i think it's okay to merge
@batrick looks like we bumped the compiler version somewhere. this was fixed for quincy in https://tracker.ceph.com/issues/50924. i've just backported that to pacific in https://github.com/ceph/ceph/pull/47304
can we find a way to summarize which files/classes in librgw_common.so and libradosgw.so are depending on these service types?
> > RGWSI_RADOS::Obj::aio_operate(read) RGWSI_RADOS::Obj::aio_operate(write) defined in services/svc_rados.cc called from rgw_aio.cc > > AIO is below. rgw_aio.cc is for rados-specific stuff, but rgw_aio.h and rgw_aio_throttle.h need to stay above the line....