maml icon indicating copy to clipboard operation
maml copied to clipboard

wrong comparison in maml.py

Open shufflebyte opened this issue 6 years ago • 0 comments

Hello, I played a little with your code and I think I found an error line in your code, see maml.py in line 120: https://github.com/cbfinn/maml/blob/master/maml.py#L120

if FLAGS.norm is not 'None':

You use the string 'None' to decide if you want to do the action, but you actually compare the object FLAGS.norm (which is a string object) and 'None'. Since "is" compares if the objects are the same, the objects are never the same, so you will perform it always. I think you want to do: if FLAGS.norm != 'None' to compare the values of both string objects.

Greetings!

shufflebyte avatar Jan 04 '20 14:01 shufflebyte