rosparam_handler icon indicating copy to clipboard operation
rosparam_handler copied to clipboard

Noetic release

Open destogl opened this issue 5 years ago • 8 comments

Are you planning to do noetic release at some point?

destogl avatar Jun 17 '20 13:06 destogl

Thanks for the reminder. I sure will release it in Noetic, but there is likely some Python 2 -> 3 port to do first. I'll have a look asap :+1:.

artivis avatar Jun 18 '20 12:06 artivis

I added the repository in my CI here and got some strange error, probably python 2 -> 3 error

destogl avatar Jun 18 '20 15:06 destogl

probably python 2 -> 3 error

Yep looks like it.

artivis avatar Jun 18 '20 15:06 artivis

I was just trying to build this on Noetic, and ran into a few issues that I think I was able to sort out. See the python3_noetic_conversion.jas branch on my fork. To release, these changes would either need to be updated to support Python 2 and 3 simultaneously, or the repo would have to adopt a Noetic and newer branching strategy as described in the ROS Python 2->3 Migration Guide. Happy to help if @artivis can take the lead on suggestions for how to PR.

jarvisschultz avatar Feb 03 '21 23:02 jarvisschultz

Hi @jarvisschultz, Thanks for taking a shot at the migration! I'm afraid I won't have time to take a look before next week but at first glance I'd say I'm fine with having a separate noetic branch.

artivis avatar Feb 04 '21 00:02 artivis

A noetic release would be great. @jarvisschultz's fork seems to work fine me.

malban avatar Jul 05 '21 01:07 malban

I'd vote for a separate branching given the chance of needing maintenance in the future may be slim (last commit on the main branch was back in 2018), and the life of the versions that depend on Python2 is known to end with a fixed term (ROS Melodic, the last LTS with Python2 support, will EoL in 2023).

130s avatar Aug 25 '21 15:08 130s

@artivis Any update on a noetic release here using the fork from @jarvisschultz ?

robo-jordo avatar Jan 18 '23 19:01 robo-jordo