Maxwell Keonwoo Kang comments

Results 27 comments of


                                            Maxwell Keonwoo Kang

Enable msbuild batching for custom rules

So I went with `fcfg_mt.ruleinputs` as fallback, which just returns `fcfg.relpath`. On supported platform (MSBuild only for now) this should expand to proper list of inputs (depends on build system)....

Enable msbuild batching for custom rules

> What do you mean by "can be batched and built incrementally"? I'll give brief example. When you have custom rule, ```lua rule 'MyCustomRule' fileextensions { '.txt' } buildcommands {...

Enable msbuild batching for custom rules

> OK, so your code is a shorthand for: Yes pretty much. > %{file.ruleinputs} seems a wrong naming: it is the name of several %{file}. rule.inputs is better IMO (but...

[Proposal]: Add `private` and `namespace` accessibility modifiers for top-level types.

+1 for this, I need this feature for my roslyn source generator. I don't want the generated `internal` classes cause conflict if user uses `[InternalsVisibleTo]`, when multiple assemblies use same...

[Proposal]: Add `private` and `namespace` accessibility modifiers for top-level types.

@VelvetThePanda Thanks for the input, I wasn't aware of `file` keyword in C# 11. However it cannot be used for my case as my SG will generate extension class that...

Received "The method or operation is not implemented." on basic Select().Sum() in Unity

Thank you for detailed bug report and support! Your issue seems like the case that source generation is not happening. All the stub methods throws `NotImplementedException` and should be replaced...

Received "The method or operation is not implemented." on basic Select().Sum() in Unity

Huh, that's odd. The compile error should not happen even if generation failed, as stub method is still there. Is it error from Unity console, or the IDE? Can you...

Make it possible to omit memory allocation for closures

Thank you for your proposal. This is interesting idea- I have two concerns about it. 1. If we put this argument in `Gen`, it may should effect all the subsequent...

Add support for nested vertical list in other vertical list or dictionary

Nested vertical list is not supported due to ambiguity of the structure. If the header looks like |Id|Values| |--|-------| |Row1|1| ||2| ||3| If the `Values` is `VerticalList Values`, it's not...

Support nullable reference type annotations

Agenda: To support this in better way, `BakingSheet` could take breaking change and make `this[TKey]` to throw exception when key does not exist. User can still use `Find` to get...