workflow-telemetry-action icon indicating copy to clipboard operation
workflow-telemetry-action copied to clipboard
verified publisher icon catchpoint

Support push event by associating with open pull requests

Open tockn opened this issue 2 years ago • 3 comments

Thank you for the wonderful project! In this Pull Request, I have made changes to allow this action to be triggered by push events as well.

Previously, the action would retrieve pull request information from the context payload and, if present, comment with the results of the metrics. However, this was only possible with pull request events. With this change, if pull request information cannot be obtained from the context, the system now retrieves open pull requests associated with the sha and comments there. This modification allows the action to operate with push events as well.

tockn avatar Jan 17 '24 03:01 tockn

Hi @tockn,

Thanks for your contribution and sorry for late reply. Could you please rebase your PR with latest changes?

serkan-ozal avatar Feb 17 '24 22:02 serkan-ozal

@serkan-ozal Hi! I've resolved the conflicts!

tockn avatar Feb 18 '24 21:02 tockn

Hey @tockn,

Apologies for late reply and slow progress. Can you please rebase again and run npm run all on your local before committing?

rwxdash avatar Mar 04 '24 14:03 rwxdash