Catch2 icon indicating copy to clipboard operation
Catch2 copied to clipboard

Move header from internal

Open oboukli opened this issue 1 year ago • 1 comments

Move catch_test_run_info.hpp from directory src/catch2/internal/ to be directly under src/catch2/.

Header catch_test_run_info.hpp defines Catch::TestRunInfo which is part of the public API, since it is required when overriding Catch::EventListenerBase.

Fixes issue caught by Clang Tidy misc-include-cleaner check.

oboukli avatar Apr 13 '25 14:04 oboukli

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.01%. Comparing base (5b3b228) to head (dfeff86). Report is 34 commits behind head on devel.

Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #2972   +/-   ##
=======================================
  Coverage   91.01%   91.01%           
=======================================
  Files         198      198           
  Lines        8599     8599           
=======================================
  Hits         7826     7826           
  Misses        773      773           
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Apr 13 '25 15:04 codecov[bot]

I spent some time thinking about this.

The change is of course technically correct. However, the change also has a good chance of breaking someone's build, while not having a large payoff. I've ended up deciding to merge the PR, because it won't break most users and the fix is easy.

horenmar avatar Jul 07 '25 15:07 horenmar