Catch2 icon indicating copy to clipboard operation
Catch2 copied to clipboard

fix: use standard main function on MinGW

Open aminya opened this issue 3 years ago • 3 comments

Description

Once you define the CATCH_CONFIG_MAIN definition on MinGW, it defines a non-standard main function called WinMain. This results in a lot of undefined references. This doesn't happen with other compilers.

This check ensures that the standard main file is used with MinGW.

GitHub Issues

Fixes #2437

aminya avatar Jun 01 '22 23:06 aminya

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.08%. Comparing base (a7782d1) to head (40d1268).

Additional details and impacted files
@@           Coverage Diff           @@
##             v2.x    #2441   +/-   ##
=======================================
  Coverage   90.08%   90.08%           
=======================================
  Files         113      113           
  Lines        5040     5040           
=======================================
  Hits         4540     4540           
  Misses        500      500           

codecov[bot] avatar Jun 02 '22 00:06 codecov[bot]

Hello there, first of all thank you for your PR. Seeing as this problem still exists / happened to me now in April of 2024, is there any reason this was never addressed/merged?

protos-gunzinger avatar Apr 18 '24 12:04 protos-gunzinger

Fixed the conflicts so that it could be merged.

aminya avatar Apr 18 '24 17:04 aminya