php-rar icon indicating copy to clipboard operation
php-rar copied to clipboard

Fix failing 041.phpt on x64 Windows

Open cmb69 opened this issue 4 years ago • 0 comments

For LLP64, a long is 32bit, what causes 041.phpt to fail on 64bit Windows. However, as of PHP 7.0.0, integers are stored as zend_long by the engine, so we can fix that test failure.


If that was the only issue regarding long, I think this patch would be okay. However, there are a lot more issues (and some are way more serious, such as passing a long* to zend_parse_parameters()), so there'd need to be an abstraction layer. Or maybe, consider to drop support for PHP < 7.0.0.

cmb69 avatar Nov 30 '21 17:11 cmb69