casper-node icon indicating copy to clipboard operation
casper-node copied to clipboard

Reject transactions for which there’s no chance for the chain to reach the required gas price

Open rafal-ch opened this issue 1 year ago • 5 comments

This PR adds another check to the transaction acceptor.

It makes the acceptor reject transactions with gas price tolerance set to a value that is not achievable by the chain within the given TTL.

Calculation is based on the assumptions that chain gas price can only go up and down by 1 every each era.

Additionally, this PR also fixes the problem with the gas price being reset after the network upgrade. With the fix, the gas price is preserved across the upgrades, which is covered by a new NCTL upgrade test in the corresponding PR.

rafal-ch avatar Aug 01 '24 10:08 rafal-ch

bors try

rafal-ch avatar Aug 01 '24 14:08 rafal-ch

try

Build succeeded:

casperlabs-bors-ng[bot] avatar Aug 01 '24 15:08 casperlabs-bors-ng[bot]

bors try

rafal-ch avatar Aug 14 '24 13:08 rafal-ch

try

Build succeeded:

casperlabs-bors-ng[bot] avatar Aug 14 '24 14:08 casperlabs-bors-ng[bot]

Moving it back to backlog

devendran-m avatar Sep 24 '24 13:09 devendran-m

After some back and forth deliberation, we decided to not include this in 2.0 rel