casper-node icon indicating copy to clipboard operation
casper-node copied to clipboard

Change networking to not deserialize incoming messages early

Open RitaMAllenCA opened this issue 2 years ago • 3 comments

The networking component should become completely agnostic of the actual component payload and only announce incoming bytes, along with a channel tag. Actual reading should be left to the components themselves. Blocks: https://github.com/casper-network/casper-node/issues/3756 (this should replace the current block on that ticket) Blocks: "Factor out additional networking logic from networking component"

this ticket really should be split into two parts: One is prepping the networking component to be able to support sending "raw" data, and the other one is actually moving the network message deserialization from raw into components. For comparison, currently data is encoded/decoded in the networking interface instead of individual components, except for consensus, which has a weird double serialization going on.

RitaMAllenCA avatar Apr 21 '23 20:04 RitaMAllenCA

This will need to be split. Half the work is in the branch containing 3bf4de589 and following (nt-juliet), whereas the second half will require additional discussion/design with the team, as it may not even be a good fit for 1.6.

marc-casperlabs avatar Jul 03 '23 12:07 marc-casperlabs

Pre tirage; run it by Jakub

devendran-m avatar May 05 '25 10:05 devendran-m

Per triage with Jakub; discuss whether the optimisation is required in the Engineering quorum.

devendran-m avatar May 13 '25 09:05 devendran-m